Remove redundant setters #2747
Closed
Remove redundant setters #2747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, the "similar message" is just I vote -0 on removing the setters. @Poolitzer what do you think? In any case, I think we should keep the tests to make sure that the attributes stay read-only. We'd just have to adapt them abit … |
|
Im always for more descriptive error messages. |
|
Closing, then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes redundant setters since trying to assign on a setter already raises an
AttributeErrorwith a similar message we provide.We can also remove the corresponding tests for this since they are implied. (Edit: removed them)