Skip to content

Fix failing pylint locally #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2021
Merged

Fix failing pylint locally #2748

merged 3 commits into from
Oct 30, 2021

Conversation

harshil21
Copy link
Member

Pylint and mypy were failing for me locally after #2646, so I updated the related files a bit. All of my local mypy failures are from the filters module, which I guess will be refactored in #2178 so didn't change that.

@harshil21 harshil21 added the ⚙️ tests affected functionality: tests label Oct 25, 2021
@harshil21 harshil21 added this to the v14 milestone Oct 25, 2021
@harshil21 harshil21 added the 📋 pending-review work status: pending-review label Oct 25, 2021
@Bibo-Joshi
Copy link
Member

Interesting that it failed for you locally while it passed the CI. Could you specify the error messages that you got?

github-actions[bot]
github-actions bot reviewed Oct 27, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

@harshil21 harshil21 added 📋 pending-merge work status: pending-merge and removed 📋 pending-review work status: pending-review labels Oct 28, 2021
Poolitzer
Poolitzer approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't failing for me, but these changes look fine.

@Bibo-Joshi Bibo-Joshi merged commit c81a087 into v14 Oct 30, 2021
@Bibo-Joshi Bibo-Joshi deleted the fix-pre-commit branch October 30, 2021 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2021
@harshil21 harshil21 removed the 📋 pending-merge work status: pending-merge label Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

@Poolitzer Poolitzer Poolitzer approved these changes

Assignees
No one assigned
Labels
⚙️ tests affected functionality: tests
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging this pull request may close these issues.
3 participants
@harshil21 @Bibo-Joshi @Poolitzer