Skip to content

Update setter error messages #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2021
Merged

Update setter error messages #2749

merged 1 commit into from
Oct 26, 2021

Conversation

harshil21
Copy link
Member

Makes the Defaults property setter message more descriptive + changes ValueError to AttributeError for the setters in ConversationHandler

@harshil21 harshil21 added the 📋 pending-review work status: pending-review label Oct 26, 2021
@harshil21 harshil21 added this to the v14 milestone Oct 26, 2021
@Bibo-Joshi Bibo-Joshi merged commit 36d09df into v14 Oct 26, 2021
@Bibo-Joshi Bibo-Joshi deleted the m-setter-errors branch October 26, 2021 16:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2021
@harshil21 harshil21 added enhancement and removed 📋 pending-review work status: pending-review labels Nov 6, 2021
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
🔌 enhancement pr description: enhancement
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging this pull request may close these issues.
2 participants
@harshil21 @Bibo-Joshi