Skip to content

Conversation

Bibo-Joshi
Copy link
Member

setup.cfg currently makes mypy shut up about a lot of things.
This tries to reduce that, which also lead to some actual improvements. Note that before #2505 this would have been way harder

Checklist for PRs

None of those really matter here …

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs

@Bibo-Joshi Bibo-Joshi added the ⚙️ type-hinting affected functionality: type-hinting label Nov 20, 2021
@Bibo-Joshi Bibo-Joshi added this to the v14 milestone Nov 20, 2021
@Bibo-Joshi Bibo-Joshi requested a review from harshil21 November 20, 2021 12:42
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a single comment

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Deepsource has more false positives again..

@Bibo-Joshi Bibo-Joshi merged commit e0726ac into v14 Nov 21, 2021
@Bibo-Joshi Bibo-Joshi deleted the make-mypy-stricter branch November 21, 2021 11:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚙️ type-hinting affected functionality: type-hinting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants