Skip to content

Doc fixes & Improvements #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 3, 2022
Merged

Doc fixes & Improvements #2822

merged 4 commits into from
Jan 3, 2022

Conversation

Bibo-Joshi
Copy link
Member

Gathering contributions to the docs here to keep the number of commits on v14 a bit lower :)

  • On merging mention all PRs in the commit message that are included in this one

@Bibo-Joshi Bibo-Joshi added the ⚙️ documentation affected functionality: documentation label Dec 17, 2021
@Bibo-Joshi Bibo-Joshi added this to the v14 milestone Dec 17, 2021
@Poolitzer Poolitzer force-pushed the v14 branch 2 times, most recently from 74c4270 to 65f3599 Compare December 18, 2021 09:52
github-actions[bot]
github-actions bot reviewed Dec 18, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

github-actions[bot]
github-actions bot reviewed Dec 18, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

github-actions[bot]
github-actions bot reviewed Dec 18, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

@Bibo-Joshi Bibo-Joshi mentioned this pull request Jan 1, 2022
Closed
@Bibo-Joshi Bibo-Joshi merged commit 7b9cd7e into v14 Jan 3, 2022
@Bibo-Joshi Bibo-Joshi deleted the doc-fixes branch January 3, 2022 08:09
Bibo-Joshi added a commit that referenced this pull request Jan 3, 2022
@Bibo-Joshi @harshil21
Documentation Fixes & Improvements (#2822)
d66297e 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
⚙️ documentation affected functionality: documentation
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging this pull request may close these issues.
2 participants
@Bibo-Joshi @harshil21