Add Dispatcher.add_handlers
#2823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bibo-Joshi
requested changes
Dec 22, 2021
This reverts commit c11ac86.
Bibo-Joshi
reviewed
Dec 23, 2021
There was a problem hiding this comment.
Thanks for the updates! one minor nitpick.
@Poolitzer are you interested in reviewing as well or are you okay if we merge?
Mentioning @david-shiko as well, since you proposed this feature :)
Poolitzer
requested changes
Dec 23, 2021
Poolitzer
approved these changes
Dec 23, 2021
Bibo-Joshi
added a commit
that referenced
this pull request
Jan 3, 2022
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2821
Also removes redundant
Dispatcher.groupsattribute (as pointed out by @david-shiko)Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)Breaking changes:
Dispatcher.groupswas removed