Skip to content

Improve Job.__getattr__ #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Improve Job.__getattr__ #2832

merged 2 commits into from
Jan 3, 2022

Conversation

Bibo-Joshi
Copy link
Member

Motivated by https://t.me/pythontelegrambotgroup/551368?thread=551284

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added new classes & modules to the docs

@Poolitzer
Copy link
Member

https://t.me/pythontelegrambotgroup/552903?thread=551284

that PR for the docs hasn't happened yet has it?

Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@Bibo-Joshi
Copy link
Member Author

that PR for the docs hasn't happened yet has it?

not yet, no. We can wait a few more days before merging …

@harshil21 harshil21 added this to the v14 milestone Dec 31, 2021
@harshil21 harshil21 added enhancement 📋 pending-merge work status: pending-merge labels Dec 31, 2021
@Bibo-Joshi Bibo-Joshi merged commit 3e279ff into v14 Jan 3, 2022
@Bibo-Joshi Bibo-Joshi deleted the job-attribute-errors branch January 3, 2022 08:07
@harshil21 harshil21 removed the 📋 pending-merge work status: pending-merge label Jan 3, 2022
Bibo-Joshi added a commit that referenced this pull request Jan 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 enhancement pr description: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants