Skip to content

Update a test and some formatting fixes #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2022
Merged

Update a test and some formatting fixes #2843

merged 3 commits into from
Jan 9, 2022

Conversation

harshil21
Copy link
Member

No description provided.

@harshil21 harshil21 added misc ⚙️ tests affected functionality: tests labels Jan 4, 2022
@harshil21 harshil21 added this to the v14 milestone Jan 4, 2022
@Bibo-Joshi
Copy link
Member

Thanks for the PR! as mentioned, most of the deepsource failures are false positives and I've already reported them as such.
the only valid one that I see is

image

which should be solvable by doing that import in a if typing.TYPE_CHEKCING clause - could you add this to this PR?

@harshil21 harshil21 added the 📋 pending-merge work status: pending-merge label Jan 6, 2022
@Bibo-Joshi Bibo-Joshi merged commit b6c2d9a into v14 Jan 9, 2022
@Bibo-Joshi Bibo-Joshi deleted the misc-fixes branch January 9, 2022 10:47
@harshil21 harshil21 removed the 📋 pending-merge work status: pending-merge label Jan 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
⚙️ tests affected functionality: tests
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging this pull request may close these issues.
2 participants
@harshil21 @Bibo-Joshi