Skip to content

Replacing git.io links #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 21, 2022
Merged

Replacing git.io links #2872

merged 15 commits into from
Jan 21, 2022

Conversation

murugu-21
Copy link
Contributor

Changed all references to git.io in reference to issue [#2861].

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@harshil21 harshil21 changed the title V14 Replacing git.io links Jan 21, 2022
@harshil21 harshil21 added the misc label Jan 21, 2022
@harshil21 harshil21 added this to the v14 milestone Jan 21, 2022
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! added two more comments.
If you haven't already, please build the docs locally and check that the changes render correctly. see the contrib guide for details on how to build the docs locally.

murugu-21 and others added 8 commits January 21, 2022 15:30
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@murugu-21
Copy link
Contributor Author

Thanks for the PR! added two more comments. If you haven't already, please build the docs locally and check that the changes render correctly. see the contrib guide for details on how to build the docs locally.

I have built and opened the documentation, but how can i check which parts changed?

@Bibo-Joshi
Copy link
Member

I have built and opened the documentation, but how can i check which parts changed?

From the edits that you made, the following are part of the documentation (I'm linking the corresponding pages on python-telegram-bot.readthdocs.org - please look at the corresponding local files instead):

In the html files, please look for the places that you have made changes to and check that they look okay and that the links are clickable + lead to the correct location.

@murugu-21
Copy link
Contributor Author

murugu-21 commented Jan 21, 2022

I have built and opened the documentation, but how can i check which parts changed?

From the edits that you made, the following are part of the documentation (I'm linking the corresponding pages on python-telegram-bot.readthdocs.org - please look at the corresponding local files instead):

In the html files, please look for the places that you have made changes to and check that they look okay and that the links are clickable + lead to the correct location.

  • Changes.rst
    image
    image

  • _dice.py
    image

  • _builders.py
    image
    image

  • _conversationhandler.py
    image

  • _extbot.py
    image

All links verified and screenshots attached from my local build for docs.

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Bibo-Joshi Bibo-Joshi merged commit 2d70838 into python-telegram-bot:v14 Jan 21, 2022
@Bibo-Joshi
Copy link
Member

Thank you for the contribution!

@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
@murugu-21 murugu-21 deleted the v14 branch March 10, 2022 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants