Skip to content

Simplify persistence #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 1, 2022
Merged

Simplify persistence #2873

merged 6 commits into from
Feb 1, 2022

Conversation

harshil21
Copy link
Member

Closes #2871

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs

@harshil21 harshil21 added 📋 pending-review work status: pending-review 🛠 refactor change type: refactor labels Jan 21, 2022
@harshil21 harshil21 added this to the v14 milestone Jan 21, 2022
Bibo-Joshi
Bibo-Joshi requested changes Jan 22, 2022
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are quick! :)

Please revert the changes to dispatcher (except maybe for _chat_data -> chat_data). they are not related to the PR and tbh they don't change much at all anyway …

@harshil21 harshil21 removed the 📋 pending-review work status: pending-review label Jan 22, 2022
Bibo-Joshi
Bibo-Joshi reviewed Jan 22, 2022
View reviewed changes
Bibo-Joshi
Bibo-Joshi approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to merge or do you want to extend this PR with dropping insert/replace_bot as discussed? I'm fine with both :)

@harshil21 Telegram GithubBot Revised
Copy link
Member Author

@Bibo-Joshi I think we can merge and probably do that in the asyncio branch since the implementation will likely change anyway

@Bibo-Joshi Telegram GithubBot Revised
Copy link
Member

@harshil21 on asyncio, we mainly change where we call the update_*_data methods, but we don't change any internals of the persistence (except from making the methods async). I would like it better for those changes to be in a different PR. We can still merge this one as is though :)

@harshil21
Copy link
Member Author

okay, lets do it in another PR then 👍🏼

@harshil21 harshil21 added the 📋 pending-merge work status: pending-merge label Feb 1, 2022
@Bibo-Joshi Bibo-Joshi merged commit 3b1a142 into v14 Feb 1, 2022
@Bibo-Joshi Bibo-Joshi deleted the simplify-persistence branch February 1, 2022 16:50
@harshil21 harshil21 removed the 📋 pending-merge work status: pending-merge label Feb 1, 2022
Bibo-Joshi pushed a commit that referenced this pull request Feb 6, 2022
@harshil21 @Bibo-Joshi
Return Plain Dicts from BasePersistence.get_*_data (#2873)
d8e3fb4
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

Assignees
No one assigned
Labels
🛠 refactor change type: refactor
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging this pull request may close these issues.
2 participants
@harshil21 @Bibo-Joshi