Skip to content

Expand and fix a filter #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2022
Merged

Expand and fix a filter #2922

merged 5 commits into from
Apr 24, 2022

Conversation

harshil21
Copy link
Member

@harshil21 harshil21 commented Mar 7, 2022

Closes #2907

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs

@harshil21 harshil21 added this to the v14 milestone Mar 7, 2022
@Bibo-Joshi Bibo-Joshi self-requested a review March 7, 2022 20:35
@harshil21 harshil21 added the 📋 do-not-merge-yet work status: do-not-merge-yet label Mar 9, 2022
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. let's merge v14 once asyncio is in there to check the CI, but that should be it :)

@Bibo-Joshi Bibo-Joshi merged commit 4de11cd into v14 Apr 24, 2022
@Bibo-Joshi Bibo-Joshi deleted the filters-sticker-and-document branch April 24, 2022 11:47
@Bibo-Joshi Bibo-Joshi mentioned this pull request Apr 24, 2022
12 tasks
@harshil21 harshil21 removed the 📋 do-not-merge-yet work status: do-not-merge-yet label Apr 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug 🔌 enhancement pr description: enhancement and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 bug pr description: bug 🔌 enhancement pr description: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants