Skip to content

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Apr 10, 2022

Fixes a bug that's due to ChatMember no longer having all the attributes of its new subclasses.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs

@Bibo-Joshi Bibo-Joshi added this to the v14 milestone Apr 10, 2022
@Bibo-Joshi Bibo-Joshi mentioned this pull request Apr 10, 2022
16 tasks
@harshil21
Copy link
Member

perhaps we can also adjust its test by testing different ChatMember classes? For e.g. ChatMemberMember to ChatMemberAdministrator

@Bibo-Joshi
Copy link
Member Author

yes, of course - left the checklist unfilld on purpose ;)

@harshil21 harshil21 added the 📋 do-not-merge-yet work status: do-not-merge-yet label Apr 11, 2022
@Bibo-Joshi Bibo-Joshi marked this pull request as ready for review April 17, 2022 14:06
@harshil21 harshil21 removed the 📋 do-not-merge-yet work status: do-not-merge-yet label Apr 26, 2022
@Bibo-Joshi Bibo-Joshi requested a review from harshil21 April 27, 2022 18:59
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just one thought:

@Bibo-Joshi Bibo-Joshi merged commit a6f14e5 into v14 Apr 27, 2022
@Bibo-Joshi Bibo-Joshi deleted the fix-cmupdated-difference branch April 27, 2022 19:55
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 bug pr description: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants