Skip to content

Conversation

Poolitzer
Copy link
Member

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts **_kwargs
  • Added new shortcuts:

    • In Chat & User for all methods that accept chat/user_id
    • In Message for all methods that accept chat_id and message_id
    • For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION
    • Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

This was a spontaneous idea and quickly done by me to avoid other work. No proper issue to close here.

@harshil21 harshil21 added this to the v14 milestone Apr 10, 2022
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just had a quick glance and let some tipicking. Still, I'd like to come back to this only after we've merged asyncio ;)

@harshil21 harshil21 added the 📋 do-not-merge-yet work status: do-not-merge-yet label Apr 11, 2022
Base automatically changed from asyncio to v14 April 24, 2022 11:19
@Bibo-Joshi Bibo-Joshi force-pushed the ChatPermissions_unrestrict branch from 792b09b to 15ec7dc Compare April 24, 2022 17:56
@harshil21 harshil21 removed the 📋 do-not-merge-yet work status: do-not-merge-yet label Apr 26, 2022
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @harshil21 do you have any comments left? If not, you can go ahead and merge IMO

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@harshil21 harshil21 merged commit abdcd19 into v14 Apr 27, 2022
@harshil21 harshil21 deleted the ChatPermissions_unrestrict branch April 27, 2022 18:18
@Bibo-Joshi Bibo-Joshi mentioned this pull request Apr 27, 2022
12 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 enhancement pr description: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants