Skip to content

Update Dependency Policy #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 3, 2022
Merged

Update Dependency Policy #2958

merged 5 commits into from
May 3, 2022

Conversation

Bibo-Joshi
Copy link
Member

Mostly as discussed in the dev chat.

Additionally makes dependabot also update the github actions dependencies - b/c why not …

based on asyncio for now to make changes visible

@Bibo-Joshi Bibo-Joshi added bug 🐛 ⚙️ tests affected functionality: tests labels Apr 18, 2022
github-actions[bot]
github-actions bot reviewed Apr 18, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

github-actions[bot]
github-actions bot reviewed Apr 18, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

harshil21
harshil21 reviewed Apr 19, 2022
View reviewed changes
harshil21
harshil21 reviewed Apr 19, 2022
View reviewed changes
harshil21
harshil21 reviewed Apr 19, 2022
View reviewed changes
Base automatically changed from asyncio to v14 April 24, 2022 11:19
@harshil21 harshil21 added this to the v20 milestone Apr 27, 2022
Poolitzer
Poolitzer requested changes Apr 27, 2022
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have so many (2) questions

@Bibo-Joshi Bibo-Joshi changed the title Dependency policy Update Dependency Policy Apr 29, 2022
Poolitzer
Poolitzer approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi Bibo-Joshi merged commit 19feeee into v14 May 3, 2022
@Bibo-Joshi Bibo-Joshi deleted the dependency-policy branch May 3, 2022 15:22
@Bibo-Joshi Bibo-Joshi mentioned this pull request May 3, 2022
Closed
Bibo-Joshi added a commit that referenced this pull request May 6, 2022
@Bibo-Joshi
Update Dependency Policy (#2958)
a491eea
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Poolitzer Poolitzer Poolitzer approved these changes

@harshil21 harshil21 harshil21 approved these changes

Assignees
No one assigned
Labels
🔌 bug pr description: bug ⚙️ tests affected functionality: tests
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging this pull request may close these issues.
3 participants
@Bibo-Joshi @Poolitzer @harshil21