Skip to content

Conversation

tsnoam
Copy link
Member

@tsnoam tsnoam commented May 25, 2016

in addition move validation code from validate.py into bot.py and delete
the former file

@coveralls
Copy link

coveralls commented May 25, 2016

Coverage Status

Changes Unknown when pulling 559d773 on tsnoam:token into * on python-telegram-bot:master*.

from telegram.utils import request
from telegram.utils.validate import validate_token

logging.getLogger(__name__).addHandler(NullHandler())
Copy link
Member

@leandrotoledo leandrotoledo May 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIR not having a NullHandler defined prints "No handler found" #21
https://docs.python.org/2/howto/logging.html#library-config

@leandrotoledo leandrotoledo added 📋 pending-reply work status: pending-reply and removed 📋 pending-review work status: pending-review labels May 26, 2016
@leandrotoledo
Copy link
Member

Made minor comments, reassigned back to @tsnoam

in addition move validation code from validate.py into bot.py and delete
the former file
@tsnoam tsnoam merged commit 561f1c3 into python-telegram-bot:master May 26, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 enhancement pr description: enhancement 📋 pending-reply work status: pending-reply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants