Skip to content

Api 6.1 #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jun 27, 2022
Merged

Api 6.1 #3112

merged 26 commits into from
Jun 27, 2022

Conversation

Poolitzer
Copy link
Member

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

If the PR contains API changes (otherwise, you can delete this passage)

  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard coded number and strings
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added or updated bot_methods.rst
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION

github-actions[bot]
github-actions bot reviewed Jun 21, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Bibo-Joshi
Bibo-Joshi requested changes Jun 21, 2022
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! :) Had a first look through the changes and left some smaller comments below. Will try to have a look at the tests later

@harshil21 harshil21 added this to the v20.0a2 milestone Jun 21, 2022
@harshil21 harshil21 added the ⚙️ bot-api affected functionality: bot-api label Jun 21, 2022
harshil21
harshil21 reviewed Jun 21, 2022
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast job!

To change:

  • parameter login_url of LoginUrl should be changed to say HTTPS.
  • Also in https://t.me/c/1161850314/4292, they removed limits for text length and caption. Should we do that too? Or just document saying that premium users' bots' can write longer captions?

Bibo-Joshi
Bibo-Joshi requested changes Jun 22, 2022
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only have a few comments for the test :)

harshil21
harshil21 reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found out why docs were failing: Also see #3112 (comment)

Bibo-Joshi
Bibo-Joshi reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think apart from the two comments below I don't have anything else to add :) extending customwebhookbot.py to use the secret_token can surely be done in this PR but can also be done later on - might be another good first issue …

Poolitzer and others added 2 commits June 23, 2022 09:10
@Poolitzer @Bibo-Joshi
Apply suggestions from Bibo-Joshi
36d613c 
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@Poolitzer
Fix: Change constant variable naming
5681ac1
harshil21
harshil21 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Poolitzer
Poolitzer commented Jun 24, 2022
View reviewed changes
Poolitzer
Poolitzer commented Jun 24, 2022
View reviewed changes
Poolitzer
Poolitzer commented Jun 24, 2022
View reviewed changes
Poolitzer
Poolitzer commented Jun 24, 2022
View reviewed changes
Poolitzer
Poolitzer commented Jun 24, 2022
View reviewed changes
Poolitzer
Poolitzer commented Jun 24, 2022
View reviewed changes
@Poolitzer Poolitzer mentioned this pull request Jun 24, 2022
Merged
Bibo-Joshi
Bibo-Joshi reviewed Jun 25, 2022
View reviewed changes
tests/test_sticker.py Outdated
async def test_premium_animation(self, bot):
# testing animation sucks a bit since we can't create a premium sticker. What we can do is
# get a sticker set which includes a premium sticker and check that specific one.
premium_sticker_chat = await bot.get_sticker_set("Flame")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_set instead of _chat?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you don't get a sticker_chat, you get a set. https://docs.python-telegram-bot.org/en/v20.0a1/telegram.bot.html#telegram.Bot.get_sticker_set ;P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my point: premium_sticker_chat -> premium_sticker_set ;P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh you meant the variable I only saw the request

@Poolitzer Poolitzer mentioned this pull request Jun 25, 2022
Closed
harshil21
harshil21 reviewed Jun 25, 2022
View reviewed changes
Poolitzer and others added 2 commits June 25, 2022 15:52
@Poolitzer @harshil21
Update telegram/ext/filters.py
454ccfe 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@Poolitzer
Fix: Proper naming of variable.
ed344ed
@Bibo-Joshi Bibo-Joshi merged commit 08e223b into master Jun 27, 2022
@Bibo-Joshi Bibo-Joshi deleted the api_6.1 branch June 27, 2022 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2022
@harshil21 harshil21 modified the milestones: v20.0a3, v20.0a2 Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

@harshil21 harshil21 harshil21 approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
⚙️ bot-api affected functionality: bot-api
Projects
None yet
Milestone
v20.0a2
Development

Successfully merging this pull request may close these issues.
3 participants
@Poolitzer @Bibo-Joshi @harshil21