Note on editing with reply markups #3121
Conversation
Methods updated: Bot.edit_message_text Bot.edit_message_caption Bot.edit_message_media
There was a problem hiding this comment.
Hi, thanks for the PR! I left two comments below.
I am not adding the note on the method
Bot.edit_message_reply_markupsince I don't think it makes sense in the first place, I hope I'm not wrong.
Why do yout think that it doesn't make sense to have the note there? people can still try to edit messages without reply markup of with ReplyKeyboardMarkup …
todo: same in the other notes Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
oops.. forgot about this one Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
As i understood it, the meaning of the note specifies that you can only edit the text of a message if it does not contain a reply markup, since that method is supposed to be used to edit the reply markup I thought it was kind of unnecessary. |
|
Thank you for the contribution! :) |
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com> Co-authored-by: David <dsb321mp@gmail.com> Co-authored-by: Harshil Mehta <37377066+harshil21@users.noreply.github.com> Co-authored-by: poolitzer <github@poolitzer.eu> Co-authored-by: Alex <53974096+ExalFabu@users.noreply.github.com>
Hi, i would like to help and contribute on #3111
Following the official documentation, the methods i updated are:
Bot.edit_message_textBot.edit_message_captionBot.edit_message_mediaI am not adding the note on the method
Bot.edit_message_reply_markupsince I don't think it makes sense in the first place, I hope I'm not wrong.Screenshots:
