more robust echobot, let roboed go #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Request updates after the last update_id | ||
| for update in bot.getUpdates(offset=update_id, timeout=10): | ||
| # chat_id is required to reply to any message | ||
| chat_id = update.message.chat_id | ||
| update_id = update.update_id + 1 | ||
| if not update.message: # we ignore updates without messages |
There was a problem hiding this comment.
Updates without messages could be edited messages since Bot 2.0 changes, nice catch.
|
Minor comments, other than that looks good to me.
|
|
Nailed it! Good to be merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a weird crash where I received an update without a message, so the call to
update.message.textcrashed it. This takes care of that and the case where an update leads to anUnauthorizedexception whenlen(bot.getUpdates()) > 1.We also say goodbye to
roboed.py, it does not teach more than echobot and I am too lazy to update its exception handling code.