Skip to content

Conversation

penguinpee
Copy link
Contributor

- copied mostly from args to attributes
- fixed language
- fixed and improved formatting
- contribution to python-telegram-bot#3109
@Bibo-Joshi Bibo-Joshi requested a review from harshil21 October 13, 2022 13:07
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Most changes are not needed and needs to be reverted, see comments below

Sandro and others added 5 commits October 13, 2022 23:01
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshil21 harshil21 added ⚙️ documentation affected functionality: documentation hacktoberfest-accepted other: hacktoberfest-accepted labels Oct 14, 2022
@harshil21 harshil21 added this to the v20.0a5 milestone Oct 14, 2022
@harshil21 harshil21 merged commit cba6107 into python-telegram-bot:doc-fixes Oct 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚙️ documentation affected functionality: documentation hacktoberfest-accepted other: hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants