Skip to content

Unified the args and attrbs of the message* classes. #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 7, 2022
Merged

Unified the args and attrbs of the message* classes. #3314

merged 21 commits into from
Nov 7, 2022

Conversation

RobiMez
Copy link
Contributor

@RobiMez RobiMez commented Oct 27, 2022

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@RobiMez
Copy link
Contributor Author

RobiMez commented Oct 27, 2022

looking into what the sphinx error is

@RobiMez RobiMez mentioned this pull request Oct 28, 2022
Closed
devops117
devops117 reviewed Oct 29, 2022
View reviewed changes
@clot27
Copy link
Member

clot27 commented Oct 30, 2022 •
edited
Loading

Hi, thanks for the PR! Although the Message() class has already been unified in #3217, and I don't see the need to add duplicate forward_sender_name in the docstrings 🤔.

harshil21
harshil21 reviewed Oct 30, 2022
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catches!

@harshil21 harshil21 added this to the v20.0b1 milestone Oct 30, 2022
@harshil21 harshil21 added ⚙️ documentation affected functionality: documentation 📋 pending-reply work status: pending-reply labels Oct 30, 2022
RobiMez and others added 3 commits November 7, 2022 17:16
@RobiMez @harshil21
Update telegram/_messageentity.py
b35d643 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@RobiMez @harshil21
Update telegram/_messageentity.py
9c5b32c 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@RobiMez
dupe
9fab68e
@harshil21 harshil21 merged commit c6e0410 into python-telegram-bot:doc-fixes Nov 7, 2022
@harshil21 harshil21 removed the 📋 pending-reply work status: pending-reply label Nov 7, 2022
@Bibo-Joshi Bibo-Joshi mentioned this pull request Nov 7, 2022
Merged
11 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshil21 harshil21 harshil21 approved these changes

+1 more reviewer

@devops117 devops117 devops117 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
⚙️ documentation affected functionality: documentation
Projects
None yet
Milestone
v20.0a5
Development

Successfully merging this pull request may close these issues.
4 participants
@RobiMez @clot27 @harshil21 @devops117