Skip to content

update: added deep link maximum character constant #3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

BAcode-X
Copy link
Contributor

Based on Telegram API doc, the parameter can only be up to 64 characters long.

Checklist

- [ ] Added new constants at `telegram.constants`

@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer October 29, 2022 12:47
@harshil21 harshil21 added this to the v20.0b1 milestone Oct 30, 2022
@Poolitzer
Copy link
Member

Hi. You added the constant above the line where it says that "the constants above this line are tested", while not adding a test. I don't think this variable needs one (and it wouldn't be fun to write either), so just move it down.

Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi Bibo-Joshi merged commit 55106d6 into python-telegram-bot:master Nov 1, 2022
@Bibo-Joshi
Copy link
Member

Thank you for the contribution :)

@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 enhancement pr description: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants