Unified args and attributes of dice and loginurl classes #3316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, @Poolitzer is there something wrong with those tests? |
harshil21
requested changes
Oct 30, 2022
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Poolitzer
requested changes
Oct 31, 2022
|
Almost forgot this one😅. Hi, the doc changes are fine, also this pr is against the doc-fixes branch so adding constants should be done in a different pr. So revert those changes.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #3109, Dice and LoginUrl class arguments docstrings and attributes docstrings are unified.