-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Move examples in docstrings to separate blocks #3326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
harshil21
merged 8 commits into
python-telegram-bot:doc-fixes
from
lemontree210:blocks-with-examples-in-docstrings-3320
Nov 5, 2022
Merged
Move examples in docstrings to separate blocks #3326
harshil21
merged 8 commits into
python-telegram-bot:doc-fixes
from
lemontree210:blocks-with-examples-in-docstrings-3320
Nov 5, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #3320 pre-commit hooks don't pass because of cyclic import in _pollanswerhandler.py
closes #3320 The word "Example" for each example bot doesn't seem to be necessary because there is now a separate block for examples pre-commit hooks don't pass because of cyclic import in _pollanswerhandler.py
closes #3320 left a couple from previous commit
lemontree210
commented
Nov 1, 2022
lemontree210
commented
Nov 1, 2022
harshil21
requested changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very well done with the PR, thank you! The comments below are just for consistency, otherwise a great job.
…gs-3320' into blocks-with-examples-in-docstrings-3320
harshil21
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3320
pre-commit hooks don't pass because of cyclic import in
_pollanswerhandler.py
.