Skip to content

Conversation

ValentijnvdBeek
Copy link
Contributor

@ValentijnvdBeek ValentijnvdBeek commented Jul 7, 2016

@tsnoam
Copy link
Member

tsnoam commented Jul 8, 2016

@Faalentijn
Thanks for your contribution.
This seems to be working.
However, if I may nitpick:

  1. please remove the redundant empty line which was added to the end of the Makefile.
  2. (if you want) add yourself to the AUTHORS.rst

and then we can merge :)

@tsnoam tsnoam added the 📋 pending-reply work status: pending-reply label Jul 8, 2016
@tsnoam tsnoam self-assigned this Jul 8, 2016
@ValentijnvdBeek ValentijnvdBeek force-pushed the master branch 5 times, most recently from 6151969 to f5fbb0c Compare July 9, 2016 00:39
@ValentijnvdBeek
Copy link
Contributor Author

I seem to have accidentally closed this pull request after I started following the guidelines more closely. Kind of fitting since I changed the scope of the pull request quite a bit.

I decided to address both my concerns by adding some of the external files (authors, changes, contrib) and grouping similar functionalities together. It is still a work in progress but I'd still like if it you could give me your feedback on it.

You can find it here.

@ValentijnvdBeek ValentijnvdBeek mentioned this pull request Jul 14, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📋 pending-reply work status: pending-reply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants