Skip to content

API 6.3 for V13 #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 6, 2022
Merged

API 6.3 for V13 #3392

merged 12 commits into from
Dec 6, 2022

Conversation

Poolitzer
Copy link
Member

Currently not implemented are the changed/new tests.

I already implemented #3381, if there was another fix related to the 6.3 changes from #3346 I missed that.

github-actions[bot]
github-actions bot reviewed Nov 25, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

github-actions[bot]
github-actions bot reviewed Nov 25, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

@harshil21 harshil21 added ⚙️ bot-api affected functionality: bot-api 🛠 backport change type: backport labels Nov 25, 2022
@harshil21 harshil21 added this to the 13.15 milestone Nov 25, 2022
Bibo-Joshi
Bibo-Joshi requested changes Nov 25, 2022
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admire your patience with v13!

harshil21
harshil21 reviewed Nov 26, 2022
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@harshil21 harshil21 added the 📋 pending-reply work status: pending-reply label Nov 27, 2022
Bibo-Joshi
Bibo-Joshi approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I didn't go through all changed lines again and also didn't read every single test, but my previous comments where addressed nicely and everything looks in order :) LGTM! Thanks for the PR, Pool!

PS: I'm going to ignore DS on v13 and codacy just complains about this branch not being analyzed - which is fine with me, since it will die soon 🥳

harshil21
harshil21 approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also did have a rough look at it, and it looks good to me as well

@Bibo-Joshi Bibo-Joshi merged commit d6c6cc2 into v13.x Dec 6, 2022
@Bibo-Joshi Bibo-Joshi deleted the v13.x_api6.3 branch December 6, 2022 09:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

@harshil21 harshil21 harshil21 approved these changes

Assignees
No one assigned
Labels
🛠 backport change type: backport ⚙️ bot-api affected functionality: bot-api 📋 pending-reply work status: pending-reply
Projects
None yet
Milestone
13.15
Development

Successfully merging this pull request may close these issues.
3 participants
@Poolitzer @Bibo-Joshi @harshil21