Skip to content

Customized concurrent handling #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Jun 2, 2023
Merged

Conversation

clot27
Copy link
Member

@clot27 clot27 commented Apr 9, 2023

Closes #3509 when done.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • [ ] Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@clot27 clot27 marked this pull request as draft April 9, 2023 17:37
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice PR @clot27 !
IMO it covers the contents of #3509 pretty well and the overvall logic looks good :) I left some comments already though I'll ofc do a proper review again once it's out of draft status .

…am-bot into customized-concurrent-handling
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial review. Will review again after tests are added, implementation looks ok to me

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! This will come out great :) I left a bunch of new comments, but nothing major IMO.

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more comments. But looking much more refined now 👍🏽

@clot27 clot27 marked this pull request as ready for review April 25, 2023 15:01
@clot27 clot27 requested review from Bibo-Joshi and harshil21 April 25, 2023 15:01
@Bibo-Joshi Bibo-Joshi added enhancement ℹ️ needs-wiki-update information: needs-wiki-update labels May 17, 2023
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new updates! I left smaller comments :) Also the docs build is failing …

Regarding the unit tests on the update processors: TBH I don't see them going in a right direction and I'm not sure how I can explain better what should be covered. I will try and write some tests myself, but please do feel free to ask anything about that if you have questions :)

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) @harshil21 do you have anything to add?

After merge, the dev-wiki should be updated to

  • elaborate on the new processor on the page on concurrency
  • mention the BaseUpdateProcessor on the architecture page. This would be a good chance to convert the graphic to a mermaid diagram

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final review. Looks much more refined and ready. Good job @clot27. Just some tiny errors caught:

clot27 and others added 2 commits June 2, 2023 16:23
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice upgrade!

@Bibo-Joshi Bibo-Joshi merged commit bf54599 into master Jun 2, 2023
@Bibo-Joshi Bibo-Joshi deleted the customized-concurrent-handling branch June 2, 2023 16:17
@Bibo-Joshi
Copy link
Member

Big thanks to @clot27 for your work and also your patience! 👏

@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2023
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 enhancement pr description: enhancement ℹ️ needs-wiki-update information: needs-wiki-update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Customizing concurrent handling of updates
3 participants