Skip to content

Maintenance Work on test_bot.py #4489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2024
Merged

Maintenance Work on test_bot.py #4489

merged 1 commit into from
Sep 21, 2024

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Sep 19, 2024 •
edited by harshil21
Loading

Trying to get things for #4271 done in smaller chunks

  • Moves a test which was incorrectly placed in WithoutRequest class
  • remove some unnecessary sleeps
  • remove a duplicate test code fragment

@Bibo-Joshi Bibo-Joshi added the ⚙️ tests affected functionality: tests label Sep 19, 2024
@Bibo-Joshi Bibo-Joshi merged commit 2eae283 into master Sep 21, 2024
27 checks passed
@Bibo-Joshi Bibo-Joshi deleted the test-bot-maintenancne branch September 21, 2024 09:34
@Bibo-Joshi Bibo-Joshi mentioned this pull request Sep 25, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshil21 harshil21 harshil21 approved these changes

Assignees
No one assigned
Labels
⚙️ tests affected functionality: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bibo-Joshi @harshil21