Fix: Type hinting on Application.add_handlers #4531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bibo-Joshi
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Hi. Thanks for the catch and also for already providing a PR!
The annotation change itself looks ok for me. However, both the docstring and method implementation will need adaption as well. See lines 1435, 1463 and 1467 (1467 doesn't need adaption, but explains why adaption of 1463 is needed). Please be sure to adapt/extend unit tests if required. I'd say this change also warrants a "versionchanged" directive. Please have a look at the PR-checklist that we link in our PR-Template :)
|
Hi! Thanks for the feedback! I've made the changes you asked, let me know if there's something wrong! |
Bibo-Joshi
requested changes
Oct 23, 2024
Bibo-Joshi
reviewed
Oct 23, 2024
Bibo-Joshi
approved these changes
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix #4530