Improved comments for clarity and details :) #4565
Conversation
There was a problem hiding this comment.
Hi. Thanks very much for your PR! AFAIK you've already discussed the changes with Poolitzer. I've added a few additional comments below. None of them are critical.
Please also have a look at the failing pre-commit checks. They are due to a few lines exceeding the line length limit of 99 chars.
examples/paymentbot.py
Outdated
| @@ -21,41 +21,44 @@ | |||
| logging.basicConfig( | |||
| format="%(asctime)s - %(name)s - %(levelname)s - %(message)s", level=logging.INFO | |||
| ) | |||
| # set higher logging level for httpx to avoid all GET and POST requests being logged | |||
| # Set a higher logging level for httpx to avoid logging every GET and POST request | |||
There was a problem hiding this comment.
this comment is used in all examples. If it's changed, I would like to have it adapted in the other examples as well
There was a problem hiding this comment.
I'm unsure whether I should revert it or apply the same change to all the other examples.
There was a problem hiding this comment.
Your call :) I'm fine with either solution. Thanks for the other updates!
There was a problem hiding this comment.
Well, I've changed it back to the original because I believe both versions explain the purpose well.
|
Passed ;) |
d66fabc
into
python-telegram-bot:doc-fixes
|
Thank you very much for the contribution! |
Improved comments for clarity and details in payment bot example: