Widen specified type for allowed_updates Application/Updater parameter
#4589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter has been inconsistently typed as either list[str] or
tuple[str] - as either is acceptable, we can widen the type to
Sequence[str] to satisfy `mypy` and/or other type checkers.
This will allow for constructs like:
```Python
application.run_polling(
allowed_updates=(
UpdateType.MESSAGE,
UpdateType.EDITED_MESSAGE,
)
)
```
which currently fails mypy (and likely other typecheckers) with an error
like:
`error: Argument "allowed_updates" to "run_polling" of "Application" hasincompatible type "tuple[UpdateType, UpdateType]"; expected "list[str] | None" [arg-type]`
nemacysts
commented
Dec 4, 2024
|
looks like |
|
Thank you for the contribution! |
cuevasrja
pushed a commit
to USB-CI3715/python-telegram-bot
that referenced
this pull request
Dec 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter has been inconsistently typed as either list[str] or tuple[str] - as either is acceptable, we can widen the type to Sequence[str] to satisfy
mypyand/or other type checkers.This will allow for constructs like:
which currently fails mypy (and likely other typecheckers) with an error like:
error: Argument "allowed_updates" to "run_polling" of "Application" hasincompatible type "tuple[UpdateType, UpdateType]"; expected "list[str] | None" [arg-type]