Update pylint pre-commit hook to support py3.13 venvs #4590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, running `pre-commit` inside a Python 3.13 venv results in errors as described in pylint-dev/pylint#10000 e.g.: ``` ************* Module telegram._bot telegram/_bot.py:26:0: E0611: No name 'Sequence' in module 'collections.abc' (no-name-in-module) ``` Bumping this hook required ignoring a new check added in pylint 3.3.0: `too-many-positional-arguments` as there's a significant amount of violations and picking a value for `--max-positional-arguments` seems non-trivial as there are functions with 80+ args (e.g., `Message::__init__()` in `telegram/_message.py`)
harshil21
approved these changes
Dec 4, 2024
|
Thank you for the contribution! |
cuevasrja
pushed a commit
to USB-CI3715/python-telegram-bot
that referenced
this pull request
Dec 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, running
pre-commitinside a Python 3.13 venv results in errors as described in pylint-dev/pylint#10000e.g.:
Bumping this hook required ignoring a new check added in pylint 3.3.0:
too-many-positional-argumentsas there's a significant amount of violations and picking a value for--max-positional-argumentsseems non-trivial as there are functions with 80+ args (e.g.,Message::__init__()intelegram/_message.py)