Skip to content

Add BaseUpdateProcessor.current_concurrent_updates #4626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 14, 2025
Merged

Add BaseUpdateProcessor.current_concurrent_updates #4626

merged 7 commits into from
Jan 14, 2025

Conversation

Bibo-Joshi
Copy link
Member

Closes #3984

@Bibo-Joshi Bibo-Joshi added the 🔌 enhancement pr description: enhancement label Dec 31, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 31, 2024 •
edited
Loading

❌ 248 Tests Failed:

Tests completed Failed Passed Skipped
6775 248 6527 483
View the top 3 failed tests by shortest run time 
tests.ext.test_applicationbuilder.TestApplicationBuilder::test_mutually_exclusive_for_bot[http_version]
Stack Traces | 0.001s run time 
No failure message available
tests.ext.test_applicationbuilder.TestApplicationBuilder::test_mutually_exclusive_for_updater[get_updates_proxy1]
Stack Traces | 0.001s run time 
No failure message available
tests.ext.test_applicationbuilder.TestApplicationBuilder::test_mutually_non_exclusive_for_updater[get_updates_write_timeout1]
Stack Traces | 0.001s run time 
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Bibo-Joshi Bibo-Joshi mentioned this pull request Jan 2, 2025
Merged
harshil21
harshil21 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clot27
clot27 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@clot27 clot27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi Bibo-Joshi merged commit f57dd52 into master Jan 14, 2025
26 checks passed
@Bibo-Joshi Bibo-Joshi deleted the feature/introspect-bup branch January 14, 2025 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshil21 harshil21 harshil21 approved these changes

@clot27 clot27 clot27 approved these changes

@Poolitzer Poolitzer Awaiting requested review from Poolitzer

Assignees
No one assigned
Labels
🔌 enhancement pr description: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a way to introspect how many updates are currently being processed concurrently
3 participants
@Bibo-Joshi @harshil21 @clot27