Skip to content

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 11, 2025

Coming soon: The Renovate bot (GitHub App) will be renamed to Mend. PRs from Renovate will soon appear from 'Mend'. Learn more here.

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - Only on Monday and Thursday ( * * * * 1,4 ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

github-actions bot pushed a commit that referenced this pull request Sep 11, 2025
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect pyproject.toml to be updated in this PR as well

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, maybe I misunderstood this PR. it doesn't seem to bump any dependencies but rather just updates the lock file to the most recent transient dependencies.
Still, the readme change is wrong.
Moreover the description says that auto-merge is disabled by config. I thought that it was enabled before renovate was merged.

@harshil21 could you please check these two things out and see if any config setting needs tweaking?

README.rst Outdated
@@ -160,7 +160,7 @@ PTB can be installed with optional dependencies:
* ``pip install "python-telegram-bot[rate-limiter]"`` installs `aiolimiter~=1.1,<1.3 <https://aiolimiter.readthedocs.io/en/stable/>`_. Use this, if you want to use ``telegram.ext.AIORateLimiter``.
* ``pip install "python-telegram-bot[webhooks]"`` installs the `tornado~=6.4 <https://www.tornadoweb.org/en/stable/>`_ library. Use this, if you want to use ``telegram.ext.Updater.start_webhook``/``telegram.ext.Application.run_webhook``.
* ``pip install "python-telegram-bot[callback-data]"`` installs the `cachetools>=5.3.3,<6.3.0 <https://cachetools.readthedocs.io/en/latest/>`_ library. Use this, if you want to use `arbitrary callback_data <https://github.com/python-telegram-bot/python-telegram-bot/wiki/Arbitrary-callback_data>`_.
* ``pip install "python-telegram-bot[job-queue]"`` installs the `APScheduler>=3.10.4,<3.12.0 <https://apscheduler.readthedocs.io/en/3.x/>`_ library. Use this, if you want to use the ``telegram.ext.JobQueue``.
* ``pip install "python-telegram-bot[job-queue]"`` installs the `APScheduler>=3.11.0,<3.12.0 <https://apscheduler.readthedocs.io/en/3.x/>`_ library. Use this, if you want to use the ``telegram.ext.JobQueue``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* ``pip install "python-telegram-bot[job-queue]"`` installs the `APScheduler>=3.11.0,<3.12.0 <https://apscheduler.readthedocs.io/en/3.x/>`_ library. Use this, if you want to use the ``telegram.ext.JobQueue``.
* ``pip install "python-telegram-bot[job-queue]"`` installs the `APScheduler>=3.10.4,<3.12.0 <https://apscheduler.readthedocs.io/en/3.x/>`_ library. Use this, if you want to use the ``telegram.ext.JobQueue``.

This should stay as before b/c that's what we specified in pyproject.toml and we want to bump the lower bound only if strictly necessary

@@ -0,0 +1,5 @@
other = "Lock file maintenance"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
other = "Lock file maintenance"
internal = "Lock file maintenance"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what label will chango automatically recognize so all dependencies updates are "internal"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mapping is currently defined here: https://github.com/python-telegram-bot/python-telegram-bot/blob/master/changes/config.py#L50
We can ofc add new labels + mapping. We can also customize the implementation even further to also depend on the author or some keyword - we can use anything from github event triggering chango. note that user-facing dependencies should be dependencies rather than internal :)

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from 84ad5bc to 6d60c11 Compare September 15, 2025 15:26
@renovate renovate bot added ⚙️ ci-cd affected functionality: ci-cd and removed dependencies labels Sep 15, 2025
@Bibo-Joshi Bibo-Joshi merged commit 94afda2 into master Sep 15, 2025
6 checks passed
@Bibo-Joshi Bibo-Joshi deleted the renovate/lock-file-maintenance branch September 15, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ ci-cd affected functionality: ci-cd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants