-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Fix Filters documentation #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you :) Do you want to add yourself to |
Actually, this fails on the flake8 pre-commit hook. To quote @bomjacob:
If you can solve this without exceeding the maximum line length of 99 characters while still producing a nice-looking doc page, that would be great. |
You could also add `# noqa` at the end of the longer line to let flake8
ignore them
Op di 25 apr. 2017 om 10:49 schreef Jannes Höke <notifications@github.com>:
… Actually, this fails on the flake8 pre-commit hook. To quote @bomjacob
<https://github.com/bomjacob>:
I think that's the original reason I had for not including those
MessageEntity in the first place, since the docs can't show it properly if
you break it into two lines either...
If you can solve this without exceeding the maximum line length of 99
characters while still producing a nice-looking doc page, that would be
great.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#570 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABWAleKcMoPSr6SiW9_XyPFx-U_Uj1qKks5rzbN_gaJpZM4NDuBY>
.
|
@Eldinnie That sounds reasonable to me |
To make sure it doesn't show up in the rendered HTML page, it should also be prepended with |
Yeah, that's some pretty hard line to break. Are you up to add the comment yourself? As it allows edits from maintainers. |
yes so to be complete: append the line that's too long with |
Ignore long line for flake
I don't get what's wrong this time, coveralls is showing all errors, not only those added by this PR :-? |
You can ignore the coveralls check for changes like this, it sometimes fucks up |
Done |
Where is that screenshot from? |
I cloned your repo/branch and built the documentation |
With Sphinx? |
Yes. |
@jh0ker autodoc maybe ignores it... dunno how to make it ignored in the docs |
Would this:
be acceptable? I think it also helps the readability by separating those 3 ending parenthesis. |
I think that is a reasonable compromise. Please use |
I didn't know the exact syntax, I added now the commit. |
Why are there so many |
I overhauled filters docs in #728 so closing this one. |
No description provided.