Skip to content

0.28.2: src/validators/_tld.txt is missing from sdist #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtelka opened this issue May 24, 2024 · 1 comment · Fixed by #379
Closed

0.28.2: src/validators/_tld.txt is missing from sdist #378

mtelka opened this issue May 24, 2024 · 1 comment · Fixed by #379
Labels
bug Issue: Works not as designed development Issue/PR: Modification in workflows, packaging, etc.

Comments

@mtelka
Copy link

mtelka commented May 24, 2024

The src/validators/_tld.txt file is missing from the 0.28.2 sdist and this is causing 20 tests to fail:

FAILED tests/test_domain.py::test_returns_true_on_valid_top_level_domain[example.com-True-False-False]
FAILED tests/test_domain.py::test_returns_true_on_valid_top_level_domain[exa_mple.com-True-False-True]
FAILED tests/test_domain.py::test_returns_true_on_valid_top_level_domain[xn----gtbspbbmkef.xn--p1ai-True-False-False]
FAILED tests/test_domain.py::test_returns_true_on_valid_top_level_domain[underscore_subdomain.example.com-True-False-True]
FAILED tests/test_domain.py::test_returns_true_on_valid_top_level_domain[someThing.versicherung.-True-True-False]
FAILED tests/test_domain.py::test_returns_true_on_valid_top_level_domain[11.com-True-False-False]
FAILED tests/test_domain.py::test_returns_true_on_valid_top_level_domain[3.cn.-True-True-False]
FAILED tests/test_domain.py::test_returns_true_on_valid_top_level_domain[_example.com-True-False-True]
FAILED tests/test_domain.py::test_returns_true_on_valid_top_level_domain[example_.com-True-False-True]
FAILED tests/test_domain.py::test_returns_true_on_valid_top_level_domain[somerandomexample.xn--fiqs8s-True-False-False]
FAILED tests/test_domain.py::test_returns_failed_validation_invalid_top_level_domain[example.266-True-False-False]
FAILED tests/test_domain.py::test_returns_failed_validation_invalid_top_level_domain[exa_mple.org_-True-False-True]
FAILED tests/test_domain.py::test_returns_failed_validation_invalid_top_level_domain[xn----gtbspbbmkef.xn-p1ai-True-False-False]
FAILED tests/test_domain.py::test_returns_failed_validation_invalid_top_level_domain[underscore_subdomain.example.flat-True-False-True]
FAILED tests/test_domain.py::test_returns_failed_validation_invalid_top_level_domain[someThing.versicherung.reddit.-True-True-False]
FAILED tests/test_domain.py::test_returns_failed_validation_invalid_top_level_domain[11.twitter-True-False-False]
FAILED tests/test_domain.py::test_returns_failed_validation_invalid_top_level_domain[3.cnx.-True-True-False]
FAILED tests/test_domain.py::test_returns_failed_validation_invalid_top_level_domain[_example.#13-True-False-True]
FAILED tests/test_domain.py::test_returns_failed_validation_invalid_top_level_domain[example_.fo-ul-True-False-True]
FAILED tests/test_domain.py::test_returns_failed_validation_invalid_top_level_domain[somerandomexample.xn-n-fiqs8s-True-False-False]
@yozachar
Copy link
Collaborator

Oh shucks! It's missing from both sdist and bdist. Weird, now while rebuilding, it does get included.

@yozachar yozachar mentioned this issue May 25, 2024
Merged
@yozachar yozachar self-assigned this May 25, 2024
@yozachar yozachar added bug Issue: Works not as designed development Issue/PR: Modification in workflows, packaging, etc. labels May 25, 2024
@yozachar yozachar removed their assignment May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue: Works not as designed development Issue/PR: Modification in workflows, packaging, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hotfix: ensure _tld.txt is in sdist and bdist yozachar/pyvalidators
2 participants
@mtelka @yozachar