Skip to content

URL validation arbitrarily supports FTP, but not other protocols #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicbou opened this issue May 18, 2017 · 3 comments · Fixed by #245
Closed

URL validation arbitrarily supports FTP, but not other protocols #55

nicbou opened this issue May 18, 2017 · 3 comments · Fixed by #245
Labels
duplicate Issue/PR: Redundant enhancement Issue/PR: A new feature outdated Issue/PR: Open for more than 3 months

Comments

@nicbou
Copy link
Contributor

nicbou commented May 18, 2017

A URL can have any of an arbitrary number of protocols, but only HTTP, HTTPS and FTP are supported. If we have to arbitrarily restrict which protocols are allowed, we should at least follow the principle of least surprise and only allow HTTP(S). FTP is a weird addition.

Alternatively, supported protocols could be supplied.
@kvesteri
Copy link
Collaborator

Fully agree on all your points. The best way would be if user could set which schemes are allowed.

@sireliah
Copy link

sireliah commented Nov 1, 2019 •
edited
Loading

Hi! I second that. The list of possibly useful schemes is provided by IANA: https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml

I think we can safely skip the historical ones, however some are nice-to-haves:

rsync://
ldap://
rmi://
redis://
mongodb://
sftp://

etc.

Let's discuss if this is feasible to include larger amount of schemes from document I posted.

@yozachar yozachar mentioned this issue Mar 14, 2023
Closed
@yozachar yozachar added duplicate Issue/PR: Redundant enhancement Issue/PR: A new feature outdated Issue/PR: Open for more than 3 months labels Mar 14, 2023
@yozachar
Copy link
Collaborator

related #40 #55

@yozachar yozachar mentioned this issue Mar 14, 2023
Closed
@yozachar yozachar mentioned this issue Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate Issue/PR: Redundant enhancement Issue/PR: A new feature outdated Issue/PR: Open for more than 3 months
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

maint: improves url module yozachar/pyvalidators
4 participants
@nicbou @kvesteri @sireliah @yozachar