Fix: Allow Special DOI Cases Used in Public Administration Tests #415
Conversation
|
Could you please provide some references? |
|
Hi! According to the official government website where the control digit calculation is explained, there is no mention of any specific DOIs being considered invalid. Moreover, the DOIs that were previously excluded are validated correctly in the most commonly used public tools: Therefore, it seems clear that these codes should not be excluded in the validation. Thank you for reviewing! |
| ("12345",), | ||
| ("X0000000T",), | ||
| ("00000000T",), | ||
| ("00000001R",), |
There was a problem hiding this comment.
If these are valid, can you please put them in the valid nif test cases?
The special cases excluded from the validation represent valid codes, used in test environments.
Thanks @MaurizioPilia! |
The validation previously excluded certain DOI codes that are actually valid and commonly used in test environments by public administration entities. These codes, although not assigned to real individuals, should be considered valid for all practical purposes.
This change ensures that the validation logic aligns with real-world usage, preventing false negatives when handling official test scenarios.
Let me know if any adjustments are needed! 🚀