fix(uri): replace lstrip("mailto:") with manual prefix removal
#418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstrip() with removesuffix()lstrip() with removeprefix()
9182503 to
dbd9946
Compare
|
@max-moser Since the package currently supports Python >=3.8, your PR will introduce an incompatibility. |
This comment was marked as outdated.
This comment was marked as outdated.
dbd9946 to
35e6a69
Compare
lstrip() with removeprefix()lstrip("mailto:") with manual prefix removal
|
updated the PR to avoid incompatibility. |
* the use of `lstrip()` here was a bit too aggressive * `removeprefix()` is only available with python 3.9+
35e6a69 to
1dbbd0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
lstrip()here was a bit too aggressive.For example:
But: