Skip to content

Use uv for streamlit_folium installation #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2025

Conversation

hansthen
Copy link
Collaborator

@hansthen hansthen commented Aug 9, 2025

This is a bit of trial and error, since I am not very familiar with uv.

@hansthen hansthen requested a review from ocefpaf August 10, 2025 12:38
Copy link
Member

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What was the motivation? I'm not against uv, but whatever we do here should work with plain pip too. If we had issues with pip we should try to solve them. If it is just speed, merge away!

@hansthen
Copy link
Collaborator Author

LGTM. What was the motivation? I'm not against uv, but whatever we do here should work with plain pip too. If we had issues with pip we should try to solve them. If it is just speed, merge away!

As part of our test suite, Frank and I added integration tests with some popular downstream packages (geopandas and streamlit-folium.) In the github workflow we used to install streamlit-folium using pip and then install the current folium into that environment and then running the tests from streamlit-folium. That stopped working because the streamlit-folium package switched to uv.

@hansthen hansthen merged commit 73f0abd into python-visualization:main Aug 12, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants