Skip to content

Get rid of string module functions, reduce types module usage #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 23, 2016
Merged

Get rid of string module functions, reduce types module usage #15

merged 4 commits into from
Mar 23, 2016

Conversation

vasily-v-ryabov
Copy link
Collaborator

This adds +4 tests passed on Py3.
Next step would be unicode/str/bytes clarification for both Pythons using from __future__ import unicode_literals (seems the most annoying thing).

@codecov-io
Copy link

Current coverage is 88.18%

Merging #15 into master will decrease coverage by -0.01% as of 96c8b2b

@@            master     #15   diff @@
======================================
  Files           10      10       
  Stmts         1847    1845     -2
  Branches         0       0       
  Methods          0       0       
======================================
- Hit           1629    1627     -2
  Partial          0       0       
  Missed         218     218

Review entire Coverage Diff as of 96c8b2b

Powered by Codecov. Updated on successful CI builds.

@vasily-v-ryabov vasily-v-ryabov merged commit f94f68f into python-xlib:master Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasily-v-ryabov @codecov-io