Skip to content

Include _data attr keys in __dir__() for better introspection #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include _data attr keys in __dir__() for better introspection #206

wants to merge 1 commit into from

Conversation

BS-Labs
Copy link

@BS-Labs BS-Labs commented Aug 24, 2021

Just adds a dir() method to protocol.rq.GetAttrData which allows the _data dict's keys to show as instance attributes. Allows for better introspection, and also enables auto-completion in, e.g., REPL.

vasily-v-ryabov
vasily-v-ryabov reviewed Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@vasily-v-ryabov vasily-v-ryabov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super() without arguments is not supported on Py2.7. When we drop Py2.7, it can be merged. Or please add an explicit argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasily-v-ryabov vasily-v-ryabov vasily-v-ryabov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BS-Labs @vasily-v-ryabov