Add support for timeout. Change from select syscall to poll #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! In this PR I added support for specifying the timeout used in sockets via an argument.
I changed the use of select syscall to poll syscall. Select syscall has a known limitation:
Taken from https://man7.org/linux/man-pages/man2/select.2.html
I also make the BaseDisplay class public because it can be useful to connect to a X11 server without making several requests to get all the extensions available.
I also added a check in parse_connection_setup method that checks if the response has a valid status. In the protocol specification page 11 and 114 you can see all the available status (0, 1 or 2).
I ran the tests with
python3 runtests.py
and all passed.I hope you can merge my changes. Any question feel free to ask.