Fix potential usage of None and Unbound variables issues #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Misnamed `src_cmap` - Uninitialized attributes and missing methods due to usage of similar classes that don't inherit the same bases - Better defaults than `None` for variables and attributes when possible and `None` has no special meaning. - Potentially unbound variables - Additional Non checks or type coersion
Avasam
commented
Nov 17, 2022
Avasam
commented
Nov 18, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
==========================================
- Coverage 78.21% 78.16% -0.06%
==========================================
Files 42 42
Lines 4705 4735 +30
==========================================
+ Hits 3680 3701 +21
- Misses 1025 1034 +9 |
…nto None-and-Unbound
|
Could I get a review on this? |
|
@python-xlib yearly bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src_cmapNonefor variables and attributes when possible andNonehas no special meaning.It is quite possible that I have made a mistake or misunderstood how something works, please validate carefully.