Skip to content

ServiceInfo should ask the first question QU if caller doesn't specify #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bdraco opened this issue Jun 27, 2021 · 0 comments · Fixed by #852
Closed

ServiceInfo should ask the first question QU if caller doesn't specify #851

bdraco opened this issue Jun 27, 2021 · 0 comments · Fixed by #852
Assignees

Comments

@bdraco
Copy link
Member

bdraco commented Jun 27, 2021

We almost always want an immediate response

@bdraco bdraco self-assigned this Jun 27, 2021
bdraco added a commit that referenced this issue Jun 27, 2021
- We want an immediate response when making a request with ServiceInfo
  by asking a QU question, most responders will not delay the response
  and respond right away to our question. This also improves compatibility
  with split networks as we may not have been able to see the response
  otherwise.  If the responder has not multicast the record recently
  it may still choose to do so in addition to responding via unicast

- Reduces traffic when there are multiple zeroconf instances running
  on the network running ServiceBrowsers

- If we don't get an answer on the first try, we ask a QM question
  in the event we can't receive a unicast response for some reason

- This change puts ServiceInfo inline with ServiceBrowser which
  also asks the first question as QU since ServiceInfo is commonly
  called from ServiceBrowser callbacks

closes #851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant