feat: improve ServiceBrowser performance by removing OrderedDict #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrderedDict is no longer needed since 3.7 is the minimum python version we support and insertion order is a strong guarantee now. Additionally we can avoid the popitem pattern since async_update_records_complete runs in the event loop and does not need to worry about thread-safety
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1148 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 22 22
Lines 2614 2615 +1
Branches 458 458
=======================================
+ Hits 2608 2609 +1
Misses 4 4
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrderedDict is no longer needed since 3.7 is the minimum python version we support and insertion order is a strong guarantee for
dictnow. Additionally we can avoid the popitem pattern since async_update_records_complete runs in the event loop and does not need to worry about thread-safety