chore: add typing, enable additional mypy checks #1514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1514 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 33 33
Lines 3382 3382
Branches 459 459
=======================================
Hits 3375 3375
Misses 5 5
Partials 2 2 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #1514 will not alter performanceComparing Summary
|
bdraco
approved these changes
Feb 10, 2025
|
Thanks @Rotzbua |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
def _eq(self, other)no_implicit_optional = trueis default since mypy v1 and could be removed.