-
Notifications
You must be signed in to change notification settings - Fork 228
chore: some Cython 3.1.0rc1 build failures #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1574 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3400 3400
Branches 461 461
=======================================
Hits 3392 3392
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1574 will not alter performanceComparing Summary
|
Removed the other change, as apparently there is no way to satisfy both ruff and cython, and limited this to that one clear fix. |
Fix `AsyncListener._respond_query()` to use `DNSIncoming` type for the `msg` argument, matching `handle_query_or_defer()`. This fixes the following error with Cython 3.1.0rc1: ``` Error compiling Cython file: ------------------------------------------------------------ ... def _cancel_any_timers_for_addr(self, addr: _str) -> None: """Cancel any future truncated packet timers for the address.""" if addr in self._timers: self._timers.pop(addr).cancel() def _respond_query( ^ ------------------------------------------------------------ src/zeroconf/_listener.py:225:4: Signature not compatible with previous declaration Error compiling Cython file: ------------------------------------------------------------ ... object port, object transport, tuple v6_flow_scope ) cpdef _respond_query( ^ ------------------------------------------------------------ src/zeroconf/_listener.pxd:51:24: Previous declaration is here ```
Okay, so the other problem is that |
change to chore so it doesn't release. Will try to fix a few more and than do a fix one at the end |
Thanks @mgorny |
Thanks! |
Fix the few build failures I've hit with Cython 3.1.0rc1. Unfortunately, I'm stuck at:
and the like. I suspect it doesn't like
override_ttls
but can't figure out how to make it work.