Added support for reading StringIO/IO instances directly. #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pythonicrubyist Just following up about this, you referenced #60 but that's this issue. Which did you mean? Thanks! |
|
@pythonicrubyist Unfortunately, creek still doesn't support IO instances directly on Please reconsider re-opening this PR to support it, because there are many use-case where we legitimately do not wish using a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
StringIOsupport to work properly we're waiting on rubyzip/rubyzip#353.If we'd like to not wait I'll throw a condition on the
@files.closecall, otherwise I'm not sure how quick that PR will be pulled in.