Skip to content

fix path encoding problems #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

AndersonBY
Copy link

No description provided.

@filmor
Copy link
Member

filmor commented Jun 16, 2023

Did you actually test this? Why should this work?

@AndersonBY
Copy link
Author

Tested with two computers. One is set to utf8 encoding on Windows. One is default encoding. Both Windows are in Chinese. Default encoding on Chinese Windows is gbk. That's the problem causing error on path containing Chinese characters.

@filmor
Copy link
Member

filmor commented Jun 16, 2023

That's all fine, but the path is taken from a unicode string and passed to a function that decodes it from UTF8 again...

@AndersonBY
Copy link
Author

Sorry I didn't dive deep into this. But it does fix my problems with Chinese characters in the path. I was using pywebview which deeps on pythonnet and it has some problems with Chinese characters' path. And the traceback points out here.

@link89
Copy link

link89 commented Jun 21, 2023

Confirm that this patch does fix the issue: #59
Hope to be included in the next release.

@link89
Copy link

link89 commented Jul 6, 2023

Hi @filmor Do you have plan to accept this PR and make a new release?

@filmor
Copy link
Member

filmor commented Aug 7, 2023

Superceded by #62, sorry for the long delay and thank you for your effort :)

@filmor filmor closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants