-
Notifications
You must be signed in to change notification settings - Fork 747
Can't add project to existing solution #1853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
in the <FullVersion>$([System.IO.File]::ReadAllText("version.txt"))</FullVersion> which points to a non-existing file. This doesn't work on Mac. You cannot even open the solution. |
This is not a supported use case. Please use a nuget package. |
To elaborate, now that I have a bit more time: This file is part of the repo and the respective code expects that to be the root of the build process. It should be possible to adjust the build props to use its own directory as the source of the lookup, but this will still not be a supported scenario. |
@matthiasburger TL;DR; you can completely remove that line and later add your own versioning if needed. |
Allows the project to be referenced in other .NET projects without adjusting its project file (#1853).
This should be fixed now. |
@filmor thanks for fixing it :) just to clarify, of course this scenario is not supported. But as long as I don't want to make custom changes on your code it's much easier to clone and pull changes instead of creating a fork and merge your changes every time :D |
Allows the project to be referenced in other .NET projects without adjusting its project file (pythonnet#1853).
Environment
Details
I wanted to add the
Python.Runtime.csproj
into my existing solution but I get following exception:The text was updated successfully, but these errors were encountered: